Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundles: Unable to delete launcher and dependency packages #734

Closed
martastain opened this issue Aug 16, 2024 · 4 comments · Fixed by #1016
Closed

Bundles: Unable to delete launcher and dependency packages #734

martastain opened this issue Aug 16, 2024 · 4 comments · Fixed by #1016
Assignees
@flynput
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@martastain
Copy link
Member

martastain commented Aug 16, 2024 •
edited by Innders
Loading

When an incorrect version of a dependency package or launcher is uploaded, there is no way to delete them from the frontend.

[DELETE] /api/desktop/installers/{filename} and [DELETE] /api/desktop/dependencyPackages/{filename} endpoints exists, so it should be just a frontend missing the right buttons/subpage

  • New tab on upload dialog that switches between manage and upload (default always upload).
  • Multi-selection of items with delete button.
  • Each column should be sortable.
  • Size should format to reasonable label bytes kb mb gb.
  • Use tanstack table.
    Image
@martastain martastain added the type: bug Something isn't working label Aug 16, 2024
@Innders
Copy link
Member

Innders commented Aug 18, 2024

Can you overwrite them?

@martastain
Copy link
Member Author

Can you overwrite them?

Yes. To overwrite the manifest record, you need to specify ?force=true, but the actual upload is PUT and it just replaces by default.

@Innders
Copy link
Member

Innders commented Aug 19, 2024

So other than being nice to be able to cleanup old/wrong uploads, this isn't actually required?

@mkolar mkolar removed the type: bug Something isn't working label Feb 7, 2025
@Innders Innders added the type: enhancement Improvement of existing functionality or minor addition label Feb 7, 2025
@Innders
Copy link
Member

Innders commented Feb 11, 2025

Pending design...

@flynput flynput linked a pull request Feb 12, 2025 that will close this issue
Settings: Delete launcher and dependency files #1016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flynput flynput

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Settings: Delete launcher and dependency files ynput/ayon-frontend
4 participants
@mkolar @martastain @Innders @flynput