Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid messages crashing the server #83

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Fix invalid messages crashing the server #83

merged 2 commits into from
Oct 13, 2021

Conversation

andrew-3kb
Copy link
Contributor

@andrew-3kb andrew-3kb commented Oct 12, 2021 •
edited by dmonad
Loading

dmonad
dmonad requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@dmonad dmonad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this makes sense.

Please just change the logging method or recommend an alternative. Happy to merge and release a new package.

bin/utils.js Show resolved Hide resolved
@dmonad dmonad merged commit a5c72c0 into yjs:master Oct 13, 2021
@dmonad
Copy link
Member

dmonad commented Oct 13, 2021

Thanks!

@dmonad
Copy link
Member

dmonad commented Oct 13, 2021

Released this in v1.3.16!

@andrew-3kb
Copy link
Contributor Author

@dmonad Thanks for the speedy response and approval! Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmonad dmonad dmonad requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid messages crash the server in a way that is un-preventable
3 participants
@andrew-3kb @dmonad @AndrewTrintTest