feat: add sha256 and sha512 support #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the original implementation followed only RFC-4226, it had only SHA1 support. This covers a lot of tokens, but secure tokens are not SHA1, but SHA2 based as described in RFC-6238. Until now, I though only hardware tokens use SHA2 (SHA256, SHA512) and maybe some edge cases, but not common. That was probably true almost 10 years ago when I originally created this tool. Today, even tho I didn't see 256 or 512 tokens yet, I think it's more common, and soon they will be used in a lot of places. Resolves #133 References: - #133 - https://www.ietf.org/rfc/rfc4226.txt - https://www.ietf.org/rfc/rfc6238.txt Signed-off-by: Victoria Nadasdi <victoria@efertone.me>
|
Additional note: |
Signed-off-by: Victoria Nadasdi <victoria@efertone.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the original implementation followed only RFC-4226, it had only SHA1 support. This covers a lot of tokens, but secure tokens are not SHA1, but SHA2 based as described in RFC-6238.
Until now, I though only hardware tokens use SHA2 (SHA256, SHA512) and maybe some edge cases, but not common. That was probably true almost 10 years ago when I originally created this tool. Today, even tho I didn't see 256 or 512 tokens yet, I think it's more common, and soon they will be used in a lot of places.
Resolves #133
References: