Make sure to include 'as' in header

yireo · Mar 4, 2024 · e009f37 · e009f37
1 parent fcde1e4
commit e009f37
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Link/LinkParser.php b/Link/LinkParser.php
@@ -83,7 +83,7 @@ private function processHeaders(HttpResponse $response)
 
         $links = [];
         foreach ($this->links as $link) {
-            $links[] = '<'.$link->getUrl().'>; rel="preload"';
+            $links[] = '<'.$link->getUrl().'>; rel="preload"; as="'.$link->getType().'"';
         }
 
         $response->setHeader('Link', implode(', ', $links));

diff --git a/Test/Integration/HeaderTest.php b/Test/Integration/HeaderTest.php
@@ -91,8 +91,17 @@ private function assertValidLink(string $link): void
         foreach ($linkParams as $linkParam) {
             $linkParam = explode('=', $linkParam);
             $this->assertEquals(2, count($linkParam));
-            $this->assertEquals('rel', trim($linkParam[0]));
-            $this->assertEquals('preload', str_replace('"', '', trim($linkParam[1])));
+            $linkParamName = trim($linkParam[0]);
+            $linkParamValue = str_replace('"', '', trim($linkParam[1]));
+            $this->assertContains($linkParamName, ['rel', 'as']);
+
+            if ($linkParamName === 'rel') {
+                $this->assertEquals('preload', $linkParamValue);
+            }
+
+            if ($linkParamName === 'as') {
+                $this->assertContains($linkParamValue, ['style', 'script', 'font']);
+            }
         }
     }
 }