Implement customer specific data in javascript component #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #20 and part of #8.
I got rid of all the customer specific code in the module and re-implemented the code in a javascript component. One customization had to be made by adding a plugin, which adds a few variables to Customer CustomerData like:
While wrapping up the changes, I ran the tests, they all succeeded. Doesn't mean much though, as there are just a few tests 😅.
All the code concerning customer data has been removed or refactored, so it would be wise to upgrade the version to 0.3.
I known it's quite a bold PR, but I think this is the best way to get around the customer data problems. If you have some suggestions, please let me know.