Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokenize empty string and treat as none #1

Merged
merged 3 commits into from
Jan 21, 2025
Merged

tokenize empty string and treat as none #1

merged 3 commits into from
Jan 21, 2025

Conversation

fiji-flo
Copy link

Description

Thanks for your work. I move that into our parser so we don't create the arg and set it to none again.

@fiji-flo fiji-flo mentioned this pull request Jan 21, 2025
Merged
yin1999
yin1999 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Owner

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better! Thanks

@yin1999 yin1999 merged commit 7a90261 into yin1999:fix-replace-emptry-string-with-none Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiji-flo @yin1999