fix: Multiple adjust should keep points #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
改变了默认行为。这个行为改变加选项控制吧 |
没改变默认行为，只是个 bug fix： 如果单个 adjustX/adjustY 被触发，它会把另一个 Y/X 的 point 给重置掉。防止 breaking change 在 #52 里特地加了 points 相关的测试用例确保不会改变原本行为。并在此 PR 添加额外测试用例来测边界情况 https://github.com/yiminghe/dom-align/pull/53/files#diff-aeeb5355cc15e047bd7ffcbb498bf173R578 再看看哈~ |
yiminghe
approved these changes
May 19, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#24172
水平、垂直有一个方向放不下重置对应方向的标记，目前这里是整个重置，导致一个方向是对的也被重置了。
cc @afc163