Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Trying to access array offset on null" warning #20294

Merged
merged 4 commits into from
Dec 9, 2024

Prefer classic `if` construct #20294

52ff9db
Select commit
Loading
Failed to load commit list.
Merged

Fix "Trying to access array offset on null" warning #20294

Prefer classic `if` construct #20294
52ff9db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 9, 2024 in 0s

63.42% (-1.43%) compared to 49cfd3b

View this Pull Request on Codecov

63.42% (-1.43%) compared to 49cfd3b

Details

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 63.42%. Comparing base (49cfd3b) to head (52ff9db).

Files with missing lines Patch % Lines
framework/caching/FileCache.php 25.00% 9 Missing ⚠️
framework/log/FileTarget.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20294      +/-   ##
============================================
- Coverage     64.84%   63.42%   -1.43%     
- Complexity    11412    11417       +5     
============================================
  Files           431      431              
  Lines         37147    37155       +8     
============================================
- Hits          24088    23565     -523     
- Misses        13059    13590     +531     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.