Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 20045. #20061

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Revert 20045. #20061

merged 1 commit into from
Nov 2, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #19808

Copy link

what-the-diff bot commented Nov 2, 2023

PR Summary

  • Bug Fix in Database Scheme Handling
    The issue Fix type boolean MYSQL. #20045 has been addressed in our database scheme (mysql/Schema.php). It involves fine-tuning the criteria we use to classify different types of data columns.

  • Code Streamlining in Testing Modules
    Within our testing code for the MySQL database scheme (mysql/SchemaTest.php) and boolean data handling (mysql/type/BooleanTest.php), we've removed the bool_col, bool_col2, and several tests. These changes simplify our codebase, making it quicker and easier to comprehend and maintain.

  • Removal of Redundant Test Class
    We've removed an entire test class called BooleanTest from mysql/type/BooleanTest.php because it was no longer necessary, further simplifying our codebase.

  • Enhancements in Boolean Value Handling
    Improvements and bug fixes have been implemented in the BooleanTest class, part of our test suite, which focuses on effectively managing boolean or true/false values across different scenarios. This leads to more accurate and reliable tests.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11c80bf) 48.01% compared to head (0263c19) 47.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20061      +/-   ##
==========================================
- Coverage   48.01%   47.56%   -0.46%     
==========================================
  Files         445      445              
  Lines       43896    43414     -482     
==========================================
- Hits        21078    20648     -430     
+ Misses      22818    22766      -52     
Files Coverage Δ
framework/db/mysql/Schema.php 85.30% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley added this to the 2.0.50 milestone Nov 2, 2023
@bizley bizley merged commit aa9adc8 into yiisoft:master Nov 2, 2023
48 of 49 checks passed
@terabytesoftw terabytesoftw deleted the revert-20045 branch November 2, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants