Optimize findBetween method (remove calling function mb_substr())

[salehhashemi1992]

Utilising mb_strrpos with an offset instead of calling the mb_substr() Call.

[what-the-diff]

PR Summary

• Improvement in 'findBetween' method in 'BaseStringHelper.php'
  • The existing code in this method was edited to enhance efficiency and readability.
    • Instead of using the variable '$subString', the function 'mb_substr' is now applied directly to the string, simplifying and cleaning up the code.
    • The positions specifying the string segment to be returned have been recalculated for better precision. 'startPos' now includes the length of 'start' to properly determine the beginning of the required segment. Similarly, 'endPos' utilizes '$string' instead of the removed '$subString'.
    • The modified returned value now benefits from 'mb_substr' applied on '$string', enhancing the precision.
  • This streamlined approach not only makes the code easier to understand but also optimizes the program's use of resources by reducing unnecessary variables.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6804fbe) 46.70% compared to head (5ce3b4e) 48.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20059      +/-   ##
==========================================
+ Coverage   46.70%   48.01%   +1.30%     
==========================================
  Files         445      445              
  Lines       43896    43896              
==========================================
+ Hits        20503    21078     +575     
+ Misses      23393    22818     -575     

Files	Coverage Δ
framework/helpers/BaseStringHelper.php	99.44% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.