yii\web\Link remove null property

[donny26utama]

I'm trying to implement yii\web\Linkable to some ActiveRecord, when I'm using yii\web\Link the result show all property. but, if I use yii\web\Link in nested array, the result only show some property what I set.

What steps will reproduce the problem?

on my table class Activerecord, I implement yii\web\Linkable
and I add function getLinks

$managerLink = new yii\web\Link([
     'href' => 'http://example.com/users/4',
     'title' => 'My Manager',
]);
return [
     'self' => 'http://example.com/users/1',
     'friends' => [
            'http://example.com/users/2',
            'http://example.com/users/3',
     ],
     'manager' => $managerLink, // $managerLink is a Link object
     'managers' => [
           'manager1' => $managerLink,
     ]
]

the result,

    . . . 
    "_links": {
        "self": {
            "href": "http://example.com/users/1"
        },
        "friends": [
            {
                "href": "http://example.com/users/2"
            },
            {
                "href": "http://example.com/users/3"
            }
        ],
        "manager": {
            "href": "http://example.com/users/4",
            "name": null,
            "type": null,
            "templated": false,
            "profile": null,
            "title": "My Manager",
            "hreflang": null
        }
    }
}

but if I make nested array (managers) like this,

$managerLink = new yii\web\Link([
     'href' => 'http://example.com/users/4',
     'title' => 'My Manager',
]);
return [
     'self' => 'http://example.com/users/1',
     'friends' => [
            'http://example.com/users/2',
            'http://example.com/users/3',
     ],
     'manager' => $managerLink, // $managerLink is a Link object
     'managers' => [
           'manager1' => $managerLink,
     ]
]

the result to be,

    . . .
    "_links": {
        "self": {
            "href": "http://example.com/users/1"
        },
        "friends": [
            {
                "href": "http://example.com/users/2"
            },
            {
                "href": "http://example.com/users/3"
            }
        ],
        "manager": {
            "href": "http://example.com/users/4",
            "name": null,
            "type": null,
            "templated": false,
            "profile": null,
            "title": "My Manager",
            "hreflang": null
        },
        "managers": {
            "manager1": {
                "href": "http://example.com/users/4",
                "title": "My Manager"
            }
        }
    }
}

What is the expected result?

    . . . 
    "_links": {
        "self": {
            "href": "http://example.com/users/1"
        },
        "friends": [
            {
                "href": "http://example.com/users/2"
            },
            {
                "href": "http://example.com/users/3"
            }
        ],
        "manager": {
            "href": "http://example.com/users/4",
            "title": "My Manager",
        }
    }
}

What do you get instead?

Maybe this is possible bug. But how I can only show some property without make yii\web\Link object in array?

Additional info

I was try to add one condition on yii\web\Link::serialize() like this,

    public static function serialize(array $links)
    {
        foreach ($links as $rel => $link) {
            if (is_array($link)) {
                foreach ($link as $i => $l) {
                    $link[$i] = $l instanceof self ? array_filter((array) $l) : ['href' => $l];
                }
                $links[$rel] = $link;
            } elseif ($link instanceof self) { // this additional my code
                $l = array_filter((array) $link); // this additional my code
                $links[$rel] = $l; // this additional my code
            } elseif (!$link instanceof self) {
                $links[$rel] = ['href' => $link];
            }
        }

        return $links;
    }

and the result would be like expected.

Q	A
Yii version	2.0.14
PHP version	7.2.22
Operating system	MacOS

[samdark]

Looks like a bug. Would you please prepare a pull request with test for it?

[donny26utama]

OK