-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statistics provider interface #510
Conversation
kalmerkaurson
commented
Jan 29, 2024
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ✔️ |
Fixed issues | #509 |
PR Summary
|
The tests passed in php 5.6.40 for me so I am not sure why it failed now. |
How about making PR into the next version https://github.com/yiisoft/yii2-queue/tree/3.0? This version suppoting minimum PHP 8.1 |
We could but it should also work in 5.6 version, as well as the later versions, because I did not change much how InfoAction receives the data. There weren't any tests made for getDoneCount so that could be the reason why the test fails now. I just need to figure out why just one test fails because the database tests all use the same testcase, and the tests pass for Mysql and Sqlite. |
I can not reproduce the php 5.6 'tests\drivers\db\PgsqlQueueTest::testDoneCount' error and I could not find anything on google about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Overall. Looks like a great idea.
This is not an issue with PHP support - removing existing classes is a clear BC break, such change cannot go directly to the 2.3.x line. I suggest restoring the deleted "InfoAction" classes and marking them as deprecated (and remove them in 3.0.0). |
I forgot deleting files isn't very user friendly, they now have the deprecated tag. The tests have to be fixed by someone else though. |
Thanks! |