Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the minimum PHP version to 8.1 #496

Merged
merged 47 commits into from
Oct 12, 2023
Merged

Setting the minimum PHP version to 8.1 #496

merged 47 commits into from
Oct 12, 2023

Conversation

s1lver
Copy link
Member

@s1lver s1lver commented Oct 11, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues

Major changes

  • Minimum PHP version raised to 8.1
  • All dependent packages updated to minimum supported PHP 8.1
  • Added strict typing
  • Removed deprecated driver yii\queue\amqp\Queue, now you need to use yii\queue\amqp_interop\Queue
  • Removed deprecated interface yii\queue\Job, now you need to use yii\queue\JobInterface
  • Removed deprecated interface yii\queue\serializers\Serializer, now you need to use yii\queue\serializers\SerializerInterface
  • Removed deprecated interface yii\queue\RetryableJob, now you need to use yii\queue\RetryableJobInterface
  • Removed deprecated class yii\queue\cli\Signal, now you need to use yii\queue\cli\SignalLoop
  • Removed deprecated class yii\queue\cli\Verbose, now you need to use yii\queue\cli\VerboseBehavior

Static analysis

  • Current PSALM level is set to 4
  • Some directories are temporarily excluded from static analysis checking

Next improvements

  • Increased code coverage by tests (>= 50% now 25%)
  • Return of tests marked as "skip"
  • Beanstalk driver update to version 5
  • Upgrading static analysis level to level two

@s1lver s1lver requested a review from terabytesoftw October 11, 2023 14:03
@terabytesoftw terabytesoftw requested a review from bizley October 11, 2023 14:07
@codecov
Copy link

codecov bot commented Oct 11, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@terabytesoftw terabytesoftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job.

phpunit.xml.dist Outdated Show resolved Hide resolved
src/InvalidJobException.php Outdated Show resolved Hide resolved
@terabytesoftw terabytesoftw merged commit 23abdee into 3.0 Oct 12, 2023
6 checks passed
@terabytesoftw terabytesoftw deleted the php_81 branch October 12, 2023 19:07
@s1lver s1lver added this to the 3.0.0 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants