Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show error for checkbox, radio, checkboxList, radioList #208

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

egrekov
Copy link
Contributor

@egrekov egrekov commented Mar 2, 2021

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #173

@bizley bizley added the pr:request for unit tests Unit tests are needed. label Mar 2, 2021
@bizley
Copy link
Member

bizley commented Mar 2, 2021

Can we get some unit tests for this?

@samdark samdark removed the pr:request for unit tests Unit tests are needed. label Mar 3, 2021
@samdark samdark added this to the 2.0.10 milestone Mar 3, 2021
@samdark samdark added status:code review The pull request needs review. type:bug Bug status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Mar 3, 2021
@samdark
Copy link
Member

samdark commented Mar 3, 2021

Looks like tests are failing...

@egrekov
Copy link
Contributor Author

egrekov commented Mar 3, 2021

Looks like tests are failing...

Yes, I'll deal with the tests a little later, it's bad that they don't run locally, it would be easier.

@samdark
Copy link
Member

samdark commented Mar 3, 2021

Don't run locally? Why?

@samdark
Copy link
Member

samdark commented Mar 3, 2021

Update from master. It may help (in case you're under Windows).

@egrekov
Copy link
Contributor Author

egrekov commented Mar 4, 2021

root@516debc04af8:/opt/app# vendor/phpunit/phpunit/phpunit --filter ActiveFieldTest
PHPUnit 4.8.34 by Sebastian Bergmann and contributors.

Runtime:        PHP 7.3.27
Configuration:  /opt/app/phpunit.xml.dist

.............

Time: 2.62 seconds, Memory: 8.00MB

OK (13 tests, 13 assertions)

src/ActiveField.php Show resolved Hide resolved
src/ActiveField.php Show resolved Hide resolved
@bizley
Copy link
Member

bizley commented Mar 4, 2021

Please add CHANGELOG entry and it should be good to go.

@egrekov
Copy link
Contributor Author

egrekov commented Mar 4, 2021

Please add CHANGELOG entry and it should be good to go.

And how to write correctly and in which block?

-2.0.10 under development
+2.0.10 March 04, 2021
 ------------------------
 
 - Enh #205: Added `Toast` widget (simialbi)
-
+- Bug #173: Fix show error for checkbox, radio, checkboxList, radioList
 
 2.0.9 November 10, 2020
 -----------------------

@bizley
Copy link
Member

bizley commented Mar 4, 2021

Don't change the date, just add new line under Enh #205: Added Toast widget (simialbi) with something like:
- Bug #173: Fix bug with error messages not being displayed for checkbox, radio, checkboxList, and radioList (egrekov)

@egrekov
Copy link
Contributor Author

egrekov commented Mar 4, 2021

Ok, CHANGELOG updated

@bizley bizley added status:ready for merge The pull request is OK to be merged. and removed status:under development Someone is working on a pull request. labels Mar 4, 2021
@samdark samdark merged commit d1af1e2 into yiisoft:master Mar 4, 2021
@samdark
Copy link
Member

samdark commented Mar 4, 2021

Thanks!

@egrekov egrekov deleted the fix-issue173 branch March 9, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for merge The pull request is OK to be merged. type:bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants