-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix show error for checkbox, radio, checkboxList, radioList #208
Conversation
egrekov
commented
Mar 2, 2021
Q | A |
---|---|
Is bugfix? | yes |
New feature? | no |
Breaks BC? | no |
Tests pass? | yes |
Fixed issues | #173 |
Can we get some unit tests for this? |
Looks like tests are failing... |
Yes, I'll deal with the tests a little later, it's bad that they don't run locally, it would be easier. |
Don't run locally? Why? |
Update from master. It may help (in case you're under Windows). |
root@516debc04af8:/opt/app# vendor/phpunit/phpunit/phpunit --filter ActiveFieldTest
PHPUnit 4.8.34 by Sebastian Bergmann and contributors.
Runtime: PHP 7.3.27
Configuration: /opt/app/phpunit.xml.dist
.............
Time: 2.62 seconds, Memory: 8.00MB
OK (13 tests, 13 assertions) |
Please add CHANGELOG entry and it should be good to go. |
And how to write correctly and in which block?
|
Don't change the date, just add new line under |
Ok, CHANGELOG updated |
Thanks! |