Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed leading spaces in closure dumps #88

Merged
merged 5 commits into from
Jun 4, 2023
Merged

Removed leading spaces in closure dumps #88

merged 5 commits into from
Jun 4, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jun 2, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Before:

function () {
        return 1;
    }

After:

function () {
    return 1;
}

@what-the-diff
Copy link

what-the-diff bot commented Jun 2, 2023

PR Summary

  • Fixed indentation for closure
    Improved code readability and consistency
  • Added new line before function body in specific tests
    Enhanced the readability of test methods in ClosureExporterTest
  • Removed unnecessary spaces at end of lines in specific tests
    Cleaned up extra spaces in VarDumperTest's data providers for better code quality

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.18 ⚠️

Comparison is base (e0e43eb) 92.61% compared to head (08d6cbf) 92.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     92.61%   92.43%   -0.18%     
- Complexity      152      156       +4     
============================================
  Files             4        4              
  Lines           352      357       +5     
============================================
+ Hits            326      330       +4     
- Misses           26       27       +1     
Impacted Files Coverage Δ
src/ClosureExporter.php 88.50% <100.00%> (-0.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a line for CHANGELOG

src/ClosureExporter.php Outdated Show resolved Hide resolved
@xepozz xepozz merged commit d478f05 into master Jun 4, 2023
@xepozz xepozz deleted the ident-closure branch June 4, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants