Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add var type #76

Merged
merged 12 commits into from
Oct 28, 2022
Merged

Add var type #76

merged 12 commits into from
Oct 28, 2022

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Oct 21, 2022

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️

It helps separate objects, resources and arrays not by implicit characteristics

@xepozz xepozz added the status:code review The pull request needs review. label Oct 21, 2022
@xepozz xepozz requested a review from a team October 21, 2022 22:44
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 92.09% // Head: 92.16% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (5d19d8f) compared to base (d2cae7b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
+ Coverage     92.09%   92.16%   +0.07%     
  Complexity      152      152              
============================================
  Files             4        4              
  Lines           329      332       +3     
============================================
+ Hits            303      306       +3     
  Misses           26       26              
Impacted Files Coverage Δ
src/VarDumper.php 93.47% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark
Copy link
Member

samdark commented Oct 23, 2022

  1. Need changelog.
  2. Does it break backwards compatibility? i.e. will debug package break?

@samdark samdark mentioned this pull request Oct 23, 2022
@xepozz
Copy link
Member Author

xepozz commented Oct 23, 2022

It doesn't actually break BC by methods signature but the method response has changed.

CHANGELOG.md Outdated
@@ -2,9 +2,10 @@

## 1.3.1 under development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.0 since response format changed.

@xepozz xepozz merged commit f4096bf into master Oct 28, 2022
@xepozz xepozz deleted the add-var-type branch October 28, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants