Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed application layer logic from UserAuth::challenge() #102

Closed
wants to merge 2 commits into from
Closed

Removed application layer logic from UserAuth::challenge() #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17529ba
Removed application layer logic from UserAuth::challenge()
olegbaturin May 16, 2024
7bfcfe9
Merge branch 'yiisoft:master' into master
olegbaturin Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/UserAuth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@

namespace Yiisoft\User;

use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Yiisoft\Auth\AuthenticationMethodInterface;
use Yiisoft\Auth\IdentityInterface;
use Yiisoft\Http\Status;

/**
* Implementation of the authentication interface for the user.
Expand All @@ -18,7 +16,7 @@ final class UserAuth implements AuthenticationMethodInterface
{
private string $authUrl = '/login';

public function __construct(private CurrentUser $currentUser, private ResponseFactoryInterface $responseFactory)
public function __construct(private CurrentUser $currentUser)
{
}

Expand All @@ -38,9 +36,7 @@ public function authenticate(ServerRequestInterface $request): ?IdentityInterfac
*/
public function challenge(ResponseInterface $response): ResponseInterface
{
return $this->responseFactory
->createResponse(Status::FOUND)
->withHeader('Location', $this->authUrl);
return $response;
}

/**
Expand Down
Loading