Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 support #276

Merged
merged 3 commits into from
Mar 25, 2025
Merged

PHP 8.4 support #276

merged 3 commits into from
Mar 25, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 22, 2025

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (84795ff) to head (e696fcf).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##              master      #276   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       221       223    +2     
===========================================
  Files             14        14           
  Lines            558       562    +4     
===========================================
+ Hits             558       562    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team March 22, 2025 06:35
@vjik vjik added the status:code review The pull request needs review. label Mar 22, 2025
Tigrov
Tigrov approved these changes Mar 24, 2025
View reviewed changes
.github/workflows/bc.yml Outdated
os: >-
['ubuntu-latest']
php: >-
['8.3']
['8.1']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 8.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced to 8.4

vjik
vjik commented Mar 25, 2025
View reviewed changes
@vjik vjik merged commit 2c21f65 into master Mar 25, 2025
20 checks passed
@vjik vjik deleted the php84 branch March 25, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tigrov Tigrov Tigrov approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjik @Tigrov @StyleCIBot