Add $ifExists and $cascade to dropTable() methods
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
============================================
+ Coverage 98.16% 98.17% +0.01%
- Complexity 228 230 +2
============================================
Files 19 19
Lines 709 713 +4
============================================
+ Hits 696 700 +4
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
added
status:code review
Tigrov
approved these changes
Mar 10, 2025
samdark
approved these changes
Mar 10, 2025
| public function dropTable(string $table, bool $ifExists = false, bool $cascade = false): string | ||
| { | ||
| if ($cascade) { | ||
| throw new NotSupportedException('MSSQL doesn\'t support cascade drop table.'); |
There was a problem hiding this comment.
It is OK for now, but maybe we should traverse schema and do delete ourselves in this case for portability reasons.
There was a problem hiding this comment.
Yes. We make it in one of future versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See yiisoft/db#880