Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlainTextDataResponseFormatter and FormatDataResponseAsPlainText #88

Merged
merged 6 commits into from
Mar 2, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 2, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Mar 2, 2024

PR Summary

  • Added PlainText Data Response Formatter
    This update introduces a new component, which will allow the system to present data in a simpler, plain text format. This makes the data easier to understand and interact with for users.

  • Introduction of FormatDataResponseAsPlainText Middleware
    This change adds a new process in our system that ensures every data response is now converted into the aforementioned simpler, plain text format, further improving accessibility and interaction for users.

  • Updated Installation Instructions
    The instructions for installing our product have been updated, removing an unnecessary step. This should make the process faster and less complicated, streamlining setup for new users.

  • Added Tests for New Components
    To ensure these new components (the plain text formatter and middleware) are robust and work as expected, a series of tests have been created and added. This allows us to verify their performance and reliability, contributing to the overall quality control of our system.

The significance of these changes is that they make our product more accessible and easier to use for non-technical users due to the plain text formatting. Furthermore, the streamlined installation process simplifies the initial setup, potentially attracting more users to our system.

Files affected by this PR:
  • CHANGELOG.md
  • README.md
  • src/Formatter/PlainTextDataResponseFormatter.php
  • src/Middleware/FormatDataResponseAsPlainText.php
  • tests/Formatter/PlainTextDataResponseFormatterTest.php
  • tests/Middleware/FormatDataResponseAsPlainTextTest.php

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (94b86d1) to head (6acab5b).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     99.65%   99.66%   +0.01%     
- Complexity      102      108       +6     
============================================
  Files            11       13       +2     
  Lines           288      298      +10     
============================================
+ Hits            287      297      +10     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team March 2, 2024 14:45
@vjik vjik added the status:code review The pull request needs review. label Mar 2, 2024
@vjik vjik merged commit 13bba5f into master Mar 2, 2024
19 checks passed
@vjik vjik deleted the plain-text branch March 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants