Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum PHP version to 8.1 and refactor code #85

Merged
merged 11 commits into from
Mar 2, 2024
Merged

Raise minimum PHP version to 8.1 and refactor code #85

merged 11 commits into from
Mar 2, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 1, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (749cefa) to head (e4c79cd).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
- Coverage     99.65%   99.65%   -0.01%     
+ Complexity      107      102       -5     
============================================
  Files            11       11              
  Lines           290      288       -2     
============================================
- Hits            289      287       -2     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Mar 1, 2024

PR Summary

  • Updates on Workflow Configurations
    The pull request modifies the workflow configurations present in multiple files in the .github/workflows directory. These configurations now consider specific paths while initiating actions during pull requests and pushes. Also, certain branches have been specified for push events. A new secret has been added for mutation.yml.

  • Addition of New Workflow Configurations
    A new workflow configuration file, rector.yml, has been added in the .github/workflows directory.

  • Updates on Project Documentation and Requirements
    The CHANGELOG.md and README.md files have been updated for better documentation. The PHP version requirement has been updated to 8.1 or higher and the requirement for the JSON PHP extension has been removed. This alteration is also reflected in composer.json file and new dependencies were added.

  • Ignored Rules for specific issues
    The psalm.xml file was updated to ignore specific issues.

  • Addition of a new rectification file
    A new rectification file, rector.php, has been added to the project files.

  • Updates on DataResponse Properties and Methods
    The DataResponse.php file and its methods have been thoroughly modified to use a private $data property.

  • Modification of Various Files and Methods
    Several files, namely DataResponseFactory.php, HtmlDataResponseFormatter.php, XmlDataResponseFormatter.php, ContentNegotiator.php, FormatDataResponse.php, have been revised. Modifications range from type hint adjustments to replacement of string position checking methods.

  • Updates on Test Files and Methods
    The test files DataResponseTest.php, XmlDataResponseFormatterTest.php, ContentNegotiatorTest.php, TestCase.php, have been altered to adapt to the changes made in the corresponding primary files.

@vjik vjik mentioned this pull request Mar 1, 2024
@vjik vjik marked this pull request as ready for review March 1, 2024 14:06
@vjik vjik requested a review from a team March 1, 2024 14:07
@vjik vjik added the status:code review The pull request needs review. label Mar 1, 2024
@vjik vjik merged commit ade0cbb into master Mar 2, 2024
21 of 22 checks passed
@vjik vjik deleted the php81 branch March 2, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants