-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httplib.h: support LibreSSL #1922
Conversation
@orbea thanks for the pull request, but I am not interested in supporting LibreSSL at this point. It because the official LibreSSL page claims it only supports OpenSSL 3 API, and the latest cpp-httplib supports only OpenSSL 3 API.
|
@yhirose Thank you for the quick reply! I think BoringSSL supports a similar version as LibreSSL?
https://boringssl.googlesource.com/boringssl/+/HEAD/PORTING.md |
Please see my comment in #1892 as below regarding BoringSSL:
So if you can accept a responsibility to maintain this LibreSSL related code, I don't mind merging your pull request. Thank you for understanding the time limitations I have for this personal project. :) |
My interest is as a Gentoo user where cpp-httplib was recently pulled in as a dependency of a program I use and I am unsure how long this will continue to be true, but if you find it acceptable I will be happy to submit libressl fixes in the future. Note that Gentoo is using stable versions which are currently lagging behind your repo, I do not maintain the package or have control over the update schedule. As explained in this libressl/portable#1092 (comment) the tests require a fix in libressl that will hopefully be merged soon and a few do not pass because of different error codes. |
@orbea thanks for the clear explanation. I understand your situation, and I am now ok to treat LibreSSL as I did for BoringSSL. |
Please send me a pull request whenever you find problems with LibreSSL. |
Its possible to build httplib with LibreSSl by reusing the BoringSSL support.