Improve README.md with some minor fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 5, 2019 12:59
We are using unknown type available in TS 3.0. The notation of TS >= 2.8 might lead to be used incompatible TS wrongly.
|
UPDATE: Add requirement of TypeScript >= 3.0. We are using TypeScript 2.x support is a feedback recieved from user, but I have not think to support. I've tried to change type from In addition, (internally used) Node Slack SDK is planned to upgrade TS to 3.3 in next major version. (slackapi/node-slack-sdk#689) It means there is no advantage to support obsolete TS from now. Because an useless warning is shown to JS user, peerDep is not added at this moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some minor fixes for README.md.
<DatePicker>props.--jsx preserve) I clarified the documentation about this.