Make stable documentation anchor links #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now GitHub is postprocessing Markdown anchor links to add prefix
user-content-to each anchor. The documentation of jsx-slack is depending on the stable anchors defined by<a name="xxx" id="xxx"></a>and every links for external page have been broken. (Anchor links to the same page are still working)So I've added
user-content-prefix to all of anchor links that are referring to external pages in the jsx-slack reference.In addition, every anchor definitions were updated to use the prefixed anchor in an obsoleted attribute
name. Theidattribute is keeping original anchor name. By making targetable with both anchors, we can make easy to move current documentation into the new site without broken links.