Update how to generate Block Kit Builder URL in demo page #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By this change we can remove a limitation of the length for preview URL.
|
Confirmed that https://deploy-preview-172--speee-jsx-slack.netlify.app/#modalListOfInformationTicketApp lets preview button work completely 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #168. We will remove a limitation of the length for preview URL.
The classic URL query could not preview the huge generated JSON in jsx-slack demo because Slack returns 414 error. (e.g. https://speee-jsx-slack.netlify.app/#modalListOfInformationTicketApp)
New Block Kit Builder allows passing JSON through hash (
#xxx) as same as our demo. It won't be prevented preview even if to pass too long URI.