Support type attribute for <ol> element #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML5 can use
type
attribute for<ol>
element to change the numbering type.And now, jsx-slack has supported
type
attribute to allow alphabetical and roman numbering.jsx-slack can render list items as mimicked text, but rendering new numbering types with keeping right-aligned is difficult with a traditional way. So we've updated how to generate spaces for indenting list item: Store the data of measured Slack font width by using Puppeteer, and generate the best indent string consisted of spaces from the width of numbering text.
By this change, the count of spaces for indent may be changed from <= v1.3.0, but would not expect visual regressions in the view of Slack client.