Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v1 branch #23

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Update v1 branch #23

merged 1 commit into from
Nov 16, 2022

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Nov 16, 2022

@yen-tt
Update WCAG github action to accept mapbox API key (#22)
cced072 
When testing wcag in search-react-ui repo, the mapbox API key is required to use Mapbox GL in storybook. Updated the workflow to optionally accept a mapbox API key as an env variable for the build step.

J=none
TEST=manual

tested in this PR: yext/search-ui-react#331, where wcag error `An API access token is required to use Mapbox GL.` is no longer present after using the workflow from this branch.
@yen-tt yen-tt requested a review from a team as a code owner November 16, 2022 16:10
oshi97
oshi97 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b1 -> v1 in the title right?

@yen-tt yen-tt changed the title Update b1 branch Update v1 branch Nov 16, 2022
@yen-tt yen-tt merged commit 7d4ca0c into v1 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshi97 oshi97 oshi97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yen-tt @oshi97