Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid map key conflict for document results #456

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Avoid map key conflict for document results #456

merged 2 commits into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. Avoid map key conflict for document results 

    We currently can't have VerticalResults for document verticals since
two results from the same entity will cause a map key conflict.
To resolve this, we are making the key the result ID and the result
index which should always be unique.

J=WAT-4282
TEST=manual,auto

Created a test document search config on the test-site which previously
failed to return VerticalResults properly due to the key error
now returns the results and updates on a new search
    @sahilvaidya
    sahilvaidya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    6ad6076 View commit details
    Browse the repository at this point in the history

  2. Update snapshots

    @github-actions
    github-actions[bot] committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    07ef449 View commit details
    Browse the repository at this point in the history