Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support clickable citation card with link #444

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

anguyen-yext2
Copy link

@anguyen-yext2 anguyen-yext2 commented Jun 26, 2024

J=CLIP-1332
TEST=auto,manual

ran npm run test and tested manually on test-site
https://github.com/yext/search-ui-react/assets/143001514/e9fb1baf-8423-4e9c-acf5-ea54f88edd54

J=CLIP-1332
TEST=auto,manual

ran `npm run test` and test manually on test-site
@anguyen-yext2 anguyen-yext2 requested a review from a team as a code owner June 26, 2024 22:57
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Current unit coverage is 92.17687074829932%
Current visual coverage is 79.31671283471837%
Current combined coverage is 92.66634288489558%

@coveralls
Copy link

Coverage Status

coverage: 85.293% (+0.05%) from 85.244%
when pulling a3048dc on dev/gda-citation-improvement
into ae5fac2 on develop.

J=CLIP-1332
TEST=auto,manual

ran `npm run test` and test manually on test-site
@coveralls
Copy link

Coverage Status

coverage: 85.276% (+0.03%) from 85.244%
when pulling 1eb42ba on dev/gda-citation-improvement
into ae5fac2 on develop.

@coveralls
Copy link

Coverage Status

coverage: 85.282% (+0.04%) from 85.244%
when pulling 25d5fda on dev/gda-citation-improvement
into ae5fac2 on develop.

@coveralls
Copy link

Coverage Status

coverage: 85.282% (+0.04%) from 85.244%
when pulling 25d5fda on dev/gda-citation-improvement
into ae5fac2 on develop.

@anguyen-yext2 anguyen-yext2 merged commit 34f207c into develop Jun 27, 2024
21 of 22 checks passed
@anguyen-yext2 anguyen-yext2 deleted the dev/gda-citation-improvement branch June 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants