Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search-headless-react dependencies version to 2.5.0-beta.3 #443

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

anguyen-yext2
Copy link

New version has queryDurationMillis as an optional field of VerticalResults

J=CLIP-1226
TEST=auto,manual

ran npm run test.
temporarily added GDA to ProductsPage in test site and verified that the appropriate gda content shows up after a vertical search.
image

New version has `queryDurationMillis` as an optional field of VerticalResults

J=CLIP-1226
TEST=auto,manual

ran `npm run test`
temporarily added GDA to ProductsPage in test site and verified that the appropriate gda content shows up after a vertical search.
@anguyen-yext2 anguyen-yext2 requested a review from a team as a code owner June 24, 2024 16:20
Copy link
Contributor

Current unit coverage is 92.12445308701993%
Current visual coverage is 79.20517560073937%
Current combined coverage is 92.61418853255589%

@coveralls
Copy link

Coverage Status

coverage: 85.244%. remained the same
when pulling d2d0b08 on dev/make-queryDurationMillis-optional
into 9779374 on develop.

@anguyen-yext2 anguyen-yext2 merged commit ae5fac2 into develop Jun 24, 2024
21 of 22 checks passed
@anguyen-yext2 anguyen-yext2 deleted the dev/make-queryDurationMillis-optional branch June 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants