Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Vulnerabilities #422

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Resolve Vulnerabilities #422

merged 4 commits into from
Feb 1, 2024

Conversation

EmilyZhang777
Copy link
Contributor

This PR addresses the following vulnerabilities under test-site:

  • bump webpack version to 5.90.0
  • remove real live api key

J=VULN-37163,VULN-38428
TEST=auto

Ran npm run test. Spun up the test site and confirmed the pages are working.

@EmilyZhang777 EmilyZhang777 requested a review from a team as a code owner January 31, 2024 23:36
@github-actions GitHub Actions
Copy link
Contributor

Current unit coverage is 92.65223955712129%
Current visual coverage is 78.38862559241706%
Current combined coverage is 93.158953722334%

@coveralls
Copy link

coveralls commented Jan 31, 2024 •
edited
Loading

Coverage Status

coverage: 85.523%. remained the same
when pulling 87a155a on dev/vulnerabilities
into bd614cb on develop.

nmanu1
nmanu1 reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the nit, lgtm!

test-site/sample.env Outdated Show resolved Hide resolved
nmanu1
nmanu1 reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're making a new patch version for these fixes, we should probably merge into a hotfix branch rather than develop. but, personally I think we might be fine without because these are just changes to our test site

@EmilyZhang777 EmilyZhang777 merged commit 4b3339a into develop Feb 1, 2024
17 of 18 checks passed
@nmanu1 nmanu1 mentioned this pull request Feb 20, 2024
Merged
nmanu1 added a commit that referenced this pull request Feb 20, 2024
@nmanu1
Bump package version to 1.5.0-beta (#426)
c7bc28e 
### Features
- Add `onDropdownInputChange` optional prop to `FilterSearch` component (#421)
- Support React 18 (#423)

### Fixes
- Resolve vulnerabilities (#422)
@nmanu1 nmanu1 mentioned this pull request Feb 23, 2024
Merged
nmanu1 added a commit that referenced this pull request Feb 23, 2024
@nmanu1
Version 1.5.0 (#428)
5dd6935 
### Features
- Added support for React 18 (#423)
- Added an optional `onDropdownInputChange` prop to `FilterSearch` (#421)

### Fixes
- Addressed vulnerabilities (#422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanu1 nmanu1 nmanu1 left review comments

@benmcginnis benmcginnis benmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilyZhang777 @coveralls @benmcginnis @nmanu1