Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom): add onDropdownInputChange optional prop to FilterSearch #421

Merged
merged 9 commits into from
Jan 24, 2024
Merged

feat(custom): add onDropdownInputChange optional prop to FilterSearch #421

merged 9 commits into from
Jan 24, 2024

Commits on Jan 23, 2024

  1. feat(custom): add onDropdownInputChange optional prop to FilterSearch 

    expose a callback prop to be called everytime after input changes in the FilterSearch component.
This enables greater customization for our Locators that are built using FilterSearch primarily

J=BACK-2765
TEST=manual
    @Jeffrey-Rhoads17
    Jeffrey-Rhoads17 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4382dd2 View commit details
    Browse the repository at this point in the history

  2. Automated update to repo's documentation from github action

    @github-actions @Jeffrey-Rhoads17
    github-actions[bot] authored and Jeffrey-Rhoads17 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ae6a70e View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    @github-actions @Jeffrey-Rhoads17
    github-actions[bot] authored and Jeffrey-Rhoads17 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4502134 View commit details
    Browse the repository at this point in the history

  4. feat(custom): update onDropdownInputSelect prop to replace default be… 

    …havior, add documentation

specify a type for the props passed into onDropdownInputSelect and pass back the searchFields used
in the FilterSearch component so we can properly remove/keep the right filters

J=BACK-2765
TEST=manual
    @Jeffrey-Rhoads17
    Jeffrey-Rhoads17 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    efb8dba View commit details
    Browse the repository at this point in the history

  5. Update snapshots

    @github-actions @Jeffrey-Rhoads17
    github-actions[bot] authored and Jeffrey-Rhoads17 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ee26218 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. docs(custom): simplify documentation, use ternary operator when onDro… 

    …pdownInputChange is specified

ensure executeFilterSearch is not called in test when onDropdownInputChange is supplied

J=BACK-2765
TEST=manual
    @Jeffrey-Rhoads17
    Jeffrey-Rhoads17 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f2c2b8f View commit details
    Browse the repository at this point in the history

  2. feat(custom): remove searchFields prop from OnDropdownInputChangeProps 

    J=BACK-2765
TEST=manual
    @Jeffrey-Rhoads17
    Jeffrey-Rhoads17 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d177678 View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    @github-actions
    github-actions[bot] committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b085205 View commit details
    Browse the repository at this point in the history

  4. fix(custom): move onDropdownInputChange prop for FilterSearch story t… 

    …o args

move executeFilterSearch check to be outside a callback

J=BACK-2765
TEST=manual
    @Jeffrey-Rhoads17
    Jeffrey-Rhoads17 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    02b2144 View commit details
    Browse the repository at this point in the history