Take snapshots without Percy #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 92.1765295887663% |
EmilyZhang777
approved these changes
Nov 30, 2023
| customSnapshotsDir, | ||
| customSnapshotIdentifier: context.id, | ||
| failureThreshold: context.id === 'geolocation--loading' || isMapboxMapStory | ||
| ? 0.005 |
There was a problem hiding this comment.
out of curiosity, does this mean the difference threshold between two snapshots?
There was a problem hiding this comment.
exactly, this means that if the image that's currently taken is more than 0.005% pixels different from the image saved in the repo, then it'll fail and trigger a snapshot update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the visual regression snapshots to use the Storybook add-on
jest-image-snapshotrather than Percy. We can now remove Percy from the repo entirely. The workflow now checks snapshots and commits any that have changed. Also, the play functions for stories are fixed so async actions are properly awaited.The loading state for the
Geolocationcomponent includes animation, so the snapshot doesn't match perfectly each time. To account for this, the threshold for failure for this story is increased to a 0.005% difference in the image rather than an exact match. We also use this threshold forMapboxMapstories because the map canvas can have slight changes.The
MapboxMapcomponent takes some time to load. I wasn't able to find a good way to detect the correct time to take a snapshot, so I added a 7500ms wait for these stories to give the map time to load before taking the snapshot. Adding more robust detection logic will be part of another item. This item will also address the snapshot for the loading story forLocationBias. Right now, we skip taking a snapshot for this story because the snapshot is blank. This is likely because geolocation permissions are disabled for the test runner, so the request for the location is automatically denied.J=BACK-2832
TEST=auto