Fix visual coverage and WCAG tests #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 92.1765295887663% |
EmilyZhang777
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make updates to the Storybook setup and stories to fix the visual coverage and WCAG checks that have been failing since the Storybook version was upgraded. These changes include
@reachpackage imports from the Storybook previewmapbox-gl, over which we have no control in terms of WCAG violationsdistis directly imported now instead of a Storybook-specificindex.cssJ=BACK-2831
TEST=auto
See that the
WCAG tests,Code Coverage, andRun Testschecks are now all passing.Note: the Semgrep check is failing because of the license of the
store2package, which was not updated in this PR.