Skip to content

Commit

Permalink
Update Workflow Versions to Remove node16 Deprecation Warnings (#437)
Browse files Browse the repository at this point in the history
### Changes

1. In accordance with [3] of [this PR](yext/slapshot-reusable-workflows#37), we updated `coverage.yml` to use `actions/download-artifact@v4`. 

2. `main.yml`, and `update-snapshots.yml` actions of this repo were also updated to stop the node 16 deprecation warnings

3. Bumped versions for [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment/releases) to v4, [peter-evans/find-comment](https://github.com/peter-evans/find-comment/releases) to v3, and [actions/github-script](https://github.com/actions/github-script/releases?page=3) to v7.
  • Loading branch information
jesuyedavid authored May 14, 2024
1 parent 5d751d1 commit e7e2da6
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
runs-on: ubuntu-latest
needs: combined_coverage
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download the current coverage
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage
path: coverage/
Expand All @@ -43,14 +43,14 @@ jobs:
coverage-file: coverage/lcov.info
id: parse-combined-coverage
- name: Find Comment
uses: peter-evans/find-comment@v2
uses: peter-evans/find-comment@v3
id: fc
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: Current visual coverage
- name: Create/Update Comment
uses: peter-evans/create-or-update-comment@v2
uses: peter-evans/create-or-update-comment@v4
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ jobs:
image: returntocorp/semgrep
if: (github.actor != 'dependabot[bot]')
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: semgrep ci
6 changes: 3 additions & 3 deletions .github/workflows/update_snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ jobs:
update_snapshots:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.BOT_REPO_SCOPED_TOKEN }}
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 18.x
registry-url: 'https://registry.npmjs.org'
Expand All @@ -31,7 +31,7 @@ jobs:
default_author: github_actions
- name: Fail job if push changes
if: steps.push-changes.outputs.pushed == 'true'
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
script: |
core.setFailed('Snapshot updates were made. A new commit with new snapshots was pushed.')
Binary file modified .storybook/snapshots/__snapshots__/mapboxmap--custom-pin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .storybook/snapshots/__snapshots__/mapboxmap--primary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit e7e2da6

Please sign in to comment.