Flip chevrons on RTL #1494
Merged
Flip chevrons on RTL #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yen-tt
approved these changes
Jul 30, 2021
oshi97
approved these changes
Jul 30, 2021
|
oh could you double check that the percy snapshot is ok and not just something spurious? |
hmm, that's odd. I'll take a look. Update: It looks fine locally. I'l re-run the snapshots. 2nd update: It looks like it was something spurious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flip chevrons for RTL
J=SLAP-1460
TEST=SLAP-1460
See that chevrons appear are reversed when using the rtl bundle