Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations POT file #1475

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Add translations POT file #1475

merged 6 commits into from
Jul 21, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jul 21, 2021

Add the POT file to the repo so that we can easily access it

Also update the translation verification script to throw an error if the extracted translations are out of date

NOTE: The translation test is failing because we don't have all the translations in yet.

J=none
TEST=manual

See that when the messages.pot file in the repo is out of date, the test fails

@cea2aj cea2aj changed the title Add translations POT file to repo Add translations POT file Jul 21, 2021
@coveralls
Copy link

coveralls commented Jul 21, 2021

Coverage Status

Coverage remained the same at 58.822% when pulling ce6ac92 on dev/add-pot-file into 6361dc3 on develop.

Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! still looks great but the translation test and unsafe-eval snapshot are derping out

@cea2aj
Copy link
Member Author

cea2aj commented Jul 21, 2021

looks great! still looks great but the translation test and unsafe-eval snapshot are derping out

the translation test is supposed to be failing because we don't have all the translations in yet

It looks like the unsafe-eval snapshot has been blank since that PR was merged in. (I didn't notice it because it was auto-approved by percy)

@cea2aj cea2aj merged commit 170c757 into develop Jul 21, 2021
@cea2aj cea2aj deleted the dev/add-pot-file branch July 21, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants