add no-unsafe-eval percy snapshot #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot use testcafe to testcafe to create a no-unsafe-eval test, because testcafe internals rely on eval. Instead, this commit adds a percy snapshot which tests the same thing - that the page loads even with a CSP that disables unsafe-eval. Note we only guarantee no unsafe-eval's for the SearchBar component. I pinned our dev dependency of regenerator-runtime to 0.13.1 to be consistent with the resolution. J=SLAP-1440 TEST=auto
yen-tt
reviewed
Jul 21, 2021
| @@ -0,0 +1,32 @@ | |||
| import puppeteer from 'puppeteer'; | |||
| import percySnapshot from '@percy/puppeteer'; | |||
There was a problem hiding this comment.
Is there a difference between using @percy/script (PercyScript setup from theme) vs @percy/puppeteer?
There was a problem hiding this comment.
they've very recently deprecated percyscript https://docs.percy.io/docs/percyscript
percyscript is basically puppetter with some VERY thing wrapping, so it should be incredibly easy to migrate
I mean just looking at the code there's almost no differences besides the boilerplate
yen-tt
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use testcafe to testcafe to create a no-unsafe-eval test, because
testcafe internals rely on eval.
Instead, this commit adds a percy snapshot which tests the same thing - that
the page loads even with a CSP that disables unsafe-eval.
Note we only guarantee no unsafe-eval's for the SearchBar component.
J=SLAP-1440
TEST=auto