add locale defaulting for SpeechRecognition and support check method #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a method to handle locale defaulting on microsoft edge. Chrome and Safari both have nice handling for strange locales like en_FAKE. Edge is more sensitive, and will throw an error if the locale is not one of its specific supported ones, or if the locale uses underscores instead of dashes. The list of locales supported in edge was generated programmatically using a script. There is documentation for the list of locales supported by Azure's Speech service, but I could not find anything saying that the SpeechRecognition implementation on Edge uses this service directly (though it seems to be the case). J=SLAP-1441 TEST=manual,auto tested the isMicrosoftEdge() function on different browsers by exposing it on ANSWERS did the same thing with transformSpeechRecognitionLocaleForEdge()
cea2aj
reviewed
Jul 15, 2021
cea2aj
reviewed
Jul 15, 2021
cea2aj
reviewed
Jul 15, 2021
cea2aj
reviewed
Jul 15, 2021
cea2aj
reviewed
Jul 16, 2021
cea2aj
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a method to handle locale defaulting on microsoft edge.
Chrome and Safari both have nice handling for strange locales like en_FAKE.
Edge is more sensitive, and will throw an error if the locale is not one
of its specific supported ones, or if the locale uses underscores instead of dashes.
The list of locales supported in edge was generated programmatically using a script.
There is documentation for the list of locales supported by Azure's Speech service,
but I could not find anything saying that the SpeechRecognition implementation on Edge
uses this service directly (though it seems to be the case).
J=SLAP-1441
TEST=manual,auto
tested the isMicrosoftEdge() function on different browsers by exposing it on ANSWERS
did the same thing with transformSpeechRecognitionLocaleForEdge()