Dev/sessiontest #1460
Merged
Dev/sessiontest #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'll wanna rebase this guy on top of develop so that it doesn't include changes from #1452 (properly implement sessionTrackingEnabled) |
cjiang2000
force-pushed
the
dev/sessiontest
branch
from
4c7a0d9
to
64abe0f
Compare
tmeyer2115
reviewed
Jul 12, 2021
package-lock.json
Outdated
| "commander": "^2.7.1", | ||
| "lodash.get": "^4.0.0", | ||
| "lodash.isequal": "^4.0.0", | ||
| "validator": "^8.0.0" |
There was a problem hiding this comment.
This seems to be causing a build error. There's no , after this line, so npm fails ti parse the package-lock
oshi97
reviewed
Jul 12, 2021
tests/core/core.js
Outdated
| @@ -3,6 +3,11 @@ import SearchConfig from '../../src/core/models/searchconfig'; | |||
| import Storage from '../../src/core/storage/storage'; | |||
| import StorageKeys from '../../src/core/storage/storagekeys'; | |||
|
|
|||
| jest.mock('../../src/core/utils/uuid'); | |||
| const foo = require('../../src/core/utils/uuid'); | |||
There was a problem hiding this comment.
does importing generateUUID like
const { generateUUID } = require('../../src/core/utils/uuid')work? If that doesn't work we should rename foo to uuid
tmeyer2115
reviewed
Jul 12, 2021
tests/core/core.js
Outdated
| @@ -41,6 +46,44 @@ describe('Search requests are created properly', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Search requests are created properly', () => { | |||
There was a problem hiding this comment.
We shouldn't have two describe blocks with the same name. We'd either put these tests in the block above or give this describe block another name.
tests/core/core.js
Outdated
| ); | ||
| }); | ||
|
|
||
| it('sessionId is passed in universal search', () => { |
There was a problem hiding this comment.
Here and below, we're verifying that sessionId is not passed in search
cjiang2000
force-pushed
the
dev/sessiontest
branch
from
6af0336
to
dc8379a
Compare
oshi97
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added sessionId testing
J=SLAP-1409
TEST=automatic
ran tests and they work as expected.