Skip to content

Commit

Permalink
send cookies in GET requests (#1489)
Browse files Browse the repository at this point in the history
This commit bumps the answers-core version, so that all GET
requests use credentials: 'include', which allow cookies to be
sent across origins.

This fixes an issue with the session-id cookie not being sent,
and therefore a new session-id being generated by the backend after
every search.

Will cherry pick this (and then test) on support/v1.8 and develop

T=TECHOPS-1384
TEST=manual

see that the session-id cookie is sent in search requests
  • Loading branch information
oshi97 authored Jul 29, 2021
1 parent 44c9c88 commit 74031d7
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
6 changes: 3 additions & 3 deletions THIRD-PARTY-NOTICES
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ MIT License

The following NPM packages may be included in this product:

- @yext/answers-core@1.2.0
- @yext/answers-core@1.3.0-beta.3

These packages each contain the following license and notice below:

Expand Down Expand Up @@ -342,7 +342,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

The following NPM packages may be included in this product:

- @yext/answers-search-ui@1.9.1
- @yext/answers-search-ui@1.9.2
- @yext/answers-storage@1.1.0

These packages each contain the following license and notice below:
Expand Down Expand Up @@ -2007,7 +2007,7 @@ SOFTWARE.

The following NPM packages may be included in this product:

- cross-fetch@3.0.6
- cross-fetch@3.1.4

These packages each contain the following license and notice below:

Expand Down
22 changes: 11 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@yext/answers-search-ui",
"version": "1.9.1",
"version": "1.9.2",
"description": "Javascript Answers Programming Interface",
"main": "dist/answers-umd.js",
"repository": {
Expand All @@ -24,10 +24,10 @@
],
"dependencies": {
"@mapbox/mapbox-gl-language": "^0.10.1",
"@yext/answers-core": "^1.2.0",
"@yext/answers-core": "^1.3.0-beta.3",
"@yext/answers-storage": "^1.1.0",
"@yext/rtf-converter": "^1.5.0",
"cross-fetch": "^3.0.6",
"cross-fetch": "^3.1.4",
"css-vars-ponyfill": "^2.4.3",
"gulp-sourcemaps": "^2.6.5",
"handlebars": "^4.7.7",
Expand Down

0 comments on commit 74031d7

Please sign in to comment.