Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DA cards feedback analytics #978

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fix DA cards feedback analytics #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion directanswercards/allfields-standard/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
{{> cta CTA linkTarget=linkTarget}}
</div>
{{/if}}
{{> footer }}
{{#if feedbackEnabled}}
{{> footer }}
{{/if}}
</div>

{{#*inline 'icon'}}
Expand Down
1 change: 1 addition & 0 deletions directanswercards/card_component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ BaseDirectAnswerCard["{{componentName}}"] = class extends ANSWERS.Component {

return super.setState({
...cardData,
feedbackEnabled: ANSWERS.getAnalyticsOptIn(),
feedbackSubmitted: data.feedbackSubmitted,
isArray: Array.isArray(this.answer.value),
cardName: `{{componentName}}`,
Expand Down
4 changes: 3 additions & 1 deletion directanswercards/documentsearch-standard/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
{{> cta CTA linkTarget=linkTarget}}
</div>
</div>
{{> footer}}
{{#if feedbackEnabled}}
{{> footer }}
{{/if}}
</div>

{{#*inline 'title'}}
Expand Down
4 changes: 3 additions & 1 deletion directanswercards/multilang-allfields-standard/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
{{> cta CTA linkTarget=linkTarget}}
</div>
{{/if}}
{{> footer }}
{{#if feedbackEnabled}}
{{> footer }}
{{/if}}
</div>

{{#*inline 'icon'}}
Expand Down
2 changes: 1 addition & 1 deletion global_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"sdkVersion": "develop", // The version of the Answers SDK to use
"sdkVersion": "release/v1.11", // The version of the Answers SDK to use
// "apiKey": "<REPLACE ME>", // The answers api key found on the experiences page. This will be provided automatically by the Yext CI system
// "experienceVersion": "<REPLACE ME>", // the Answers Experience version to use for API requests. This will be provided automatically by the Yext CI system
// "businessId": "<REPLACE ME>", // The business ID of the account. This will be provided automatically by the Yext CI system
Expand Down
2 changes: 1 addition & 1 deletion test-site/config/global_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"sdkVersion": "develop", // The version of the Answers SDK to use
"sdkVersion": "release/v1.11", // The version of the Answers SDK to use
"apiKey": "2d8c550071a64ea23e263118a2b0680b", // The answers api key found on the experiences page. This will be provided automatically by the Yext CI system
// "experienceVersion": "<REPLACE ME>", // the Answers Experience version to use for API requests. This will be provided automatically by the Yext CI system
// "businessId": "<REPLACE ME>", // The business ID of the account. This will be provided automatically by the Yext CI system
Expand Down