QA item: use site locale for price range as default #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update priceRange formatter function to determined the price range string in following order: - use provided country code to determine the currency symbol - if country code is invalid or undefined, use site locale to determine the currency symbol - if all else fails, return the default price range, which is in $ TEST=auto add more cases in jest test, all passed
oshi97
reviewed
Sep 13, 2021
nmanu1
reviewed
Sep 13, 2021
added 2 commits
September 13, 2021 16:19
oshi97
reviewed
Sep 13, 2021
| if (currencySymbol) { | ||
| return defaultPriceRange.replace(/\$/g, currencySymbol); | ||
| } | ||
| } | ||
| console.warn(`Unable to determine currency symbol from ISO country code ${countryCode}.`); | ||
| const { region, language } = parseLocale(_getDocumentLocale()); |
There was a problem hiding this comment.
does getDocumentLocale need to be updated to use parseLocale?
There was a problem hiding this comment.
I think it's fine to keep it as is since there are multiple locations that invoke this method to get the locale as a single string as is. If there's a place, like in priceRange, that requires some parsing then they can use parseLocale to get each sections.
There was a problem hiding this comment.
ok sounds like the other formatters are ok with chinese!
oshi97
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST=auto
add more cases in jest test, all passed