Add table header translations #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEST=none
tmeyer2115
reviewed
Aug 19, 2021
| [TableHeaders.DAY_OF_WEEK]: 'Veckodag', | ||
| [TableHeaders.HOURS]: 'Timmar' | ||
| } | ||
| case 'zh-CH': |
There was a problem hiding this comment.
We're actually in the process of cutting over to 'zh-Hans' and 'zh-Hant'. Turns out, that's what LiveAPI and KG use instead. We want to be consistent with the rest of Yext. You should just be able to update the key names here.
static/js/utils.js
Outdated
| * @returns {string} language | ||
| */ | ||
| export function getLanguageFromLocale(locale) { | ||
| const language = (locale === 'zh-CN' || locale === 'zh-TW') |
There was a problem hiding this comment.
I see that connor made a parse locale function in his pr. will use it here once that's merge
cea2aj
reviewed
Aug 19, 2021
static/js/open-status-i18n.js
Outdated
| const language = (locale === 'zh-CN' || locale === 'zh-TW') ? | ||
| locale : | ||
| locale.substring(0,2); | ||
| const language = getLanguageFromLocale(locale); |
There was a problem hiding this comment.
I have a PR open for the open status translations (#927) so this isn't needed here
cea2aj
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST=none