use partials in validator #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new partials param in templatedatavalidator instead of fs.existsSync. This is slightly more robust, for weird cases when somebody registers a card or universalsectiontemplate in an atypical folder. J=SLAP-1489 TEST=manual test that the validator will catch incorrect card and unviersalsectiontemplates
tmeyer2115
reviewed
Aug 12, 2021
tmeyer2115
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new partials param in templatedatavalidator instead of fs.existsSync.
This is slightly more robust, for weird cases when somebody registers a card
or universalsectiontemplate in an atypical folder (for example consulting).
J=SLAP-1489
TEST=manual
test that the validator will catch incorrect card and unviersalsectiontemplates