Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix voice icon shifting #905

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Fix voice icon shifting #905

merged 1 commit into from
Aug 4, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Aug 3, 2021

Fix shifting of the voice icon which occurs when clicking the clear button

J=SLAP-1473
TEST=manual

Click the clear button and confirm the icon no longer shifts. Test with the default voice icon SVGs and with custom images

@coveralls
Copy link

Coverage Status

Coverage remained the same at 6.43% when pulling 71c3a57 on dev/fix-voice-icon-shifting into 4c98ea8 on develop.

oshi97
oshi97 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be nice to organize this file a little bit in the future, maybe with mixins or something

@cea2aj cea2aj merged commit d65dd87 into develop Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshi97 oshi97 oshi97 approved these changes

@yen-tt yen-tt Awaiting requested review from yen-tt

@cjiang2000 cjiang2000 Awaiting requested review from cjiang2000

@tmeyer2115 tmeyer2115 Awaiting requested review from tmeyer2115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cea2aj @coveralls @oshi97