Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post SessionID to Parent #882

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Post SessionID to Parent #882

merged 1 commit into from
Jul 15, 2021

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Jul 15, 2021

send the sessionId in the same message that the queryId is being sent

J=SLAP-1450
TEST=manual

Launched iframe test site, performed a search and verified through console log in iframe-common.js onMessage() that a message is delivered to parent page with queryId and sessionId.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 6.67% when pulling e07c86e on dev/post-sessionID-to-parent into bb86a14 on develop.

@oshi97
Copy link
Contributor

oshi97 commented Jul 15, 2021

I know the item says this should go in develop, but I thought this would only be needed in the case deflection branch?

@yen-tt
Copy link
Contributor Author

yen-tt commented Jul 15, 2021

I know the item says this should go in develop, but I thought this would only be needed in the case deflection branch?

@cea2aj commits in case deflection feature branch is also in develop so I assume both need to be updated?

@cea2aj
Copy link
Member

cea2aj commented Jul 15, 2021

I know the item says this should go in develop, but I thought this would only be needed in the case deflection branch?

@cea2aj commits in case deflection feature branch is also in develop so I assume both need to be updated?

yes, we are putting case deflection work in a feature branch and in develop

@oshi97
Copy link
Contributor

oshi97 commented Jul 15, 2021

I know the item says this should go in develop, but I thought this would only be needed in the case deflection branch?

@cea2aj commits in case deflection feature branch is also in develop so I assume both need to be updated?

yes, we are putting case deflection work in a feature branch and in develop

okay cool! for some reason I was imagining we would cherry-pick this into the feature branch, but it probably makes more sense to just to rebase the feature branch onto develop

@yen-tt yen-tt merged commit 4879d39 into develop Jul 15, 2021
@yen-tt yen-tt deleted the dev/post-sessionID-to-parent branch July 15, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants