Send QueryId to the Parent for iframe integrations #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
approved these changes
Jul 13, 2021
| * and the iFrameResize onMessage function must be modified. | ||
| */ | ||
|
|
||
| ANSWERS.core.storage.registerListener({ |
There was a problem hiding this comment.
Outside the scope of this PR, but I might make an item to have a top-level registerListener on ANSWERS. That way, we're not adding references to implementation details like ANSWERS.core.storage. The cat's already out of the bag, the Theme is using that other places. But, if we have a top-level ANSWERS method, might save us some trouble if we ever change internal storage details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a iframe-messaging script partial which can be used to send messages to the parent site in iframe integrations
The iframe-common.js script must be overridden in order to listen to these queryId messages.
J=SLAP-1439
TEST=manual
Override the iframe-common script and print all messages received by the parent frame. Observe a message being received on every search which includes the queryId.