Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test site speedup #862

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Test site speedup #862

merged 1 commit into from
Jun 29, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jun 29, 2021

Speed up the test site build step by moving some work from the build step to the setup step

The setup-test-site command now does all the work to generate the jambo test site, and the build command does a regular npx jambo build && grunt webpack

By moving the card and the vertical generation work to the setup step, the build step improves from 21.9 seconds to 7.4 seconds on my laptop. The downside is that some changes will now require a full setup to be ran where before it was possible to apply the change with the build command:

  • Updating page templates
  • Updating patch files
  • Updating the page config files

J=none
TEST=manual

Test the speed improvements and smoke test the test site

@coveralls
Copy link

Coverage Status

Coverage remained the same at 6.352% when pulling 79b05a2 on dev/test-site-speedup into 6402079 on develop.

@tmeyer2115 tmeyer2115 self-requested a review June 29, 2021 12:38
@cea2aj cea2aj merged commit c7edd93 into develop Jun 29, 2021
@cea2aj cea2aj deleted the dev/test-site-speedup branch June 29, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants