Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnswersExperienceFrame unit tests #855

Merged
merged 1 commit into from
Jun 28, 2021
Merged

AnswersExperienceFrame unit tests #855

merged 1 commit into from
Jun 28, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jun 28, 2021

Add tests for AnswersExperienceFrame

I created a jest mock for iframe-common so that we could check the interaction with the sendToIframe function

J=SLAP-1371
TEST=auto

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 6.171% when pulling 398de54 on dev/answers-experience-frame-tests into 0f39c75 on develop.

oshi97
oshi97 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@oshi97 oshi97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the mock!

@cea2aj cea2aj merged commit fb78175 into develop Jun 28, 2021
@cea2aj cea2aj changed the title AnswersExperienceFrame Unit tests AnswersExperienceFrame unit tests Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshi97 oshi97 oshi97 approved these changes

@tmeyer2115 tmeyer2115 tmeyer2115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cea2aj @coveralls @oshi97 @tmeyer2115